fix: remove kubernetes cli call when there is no config#4841
Open
dustinblackman wants to merge 1 commit intolima-vm:masterfrom
Open
fix: remove kubernetes cli call when there is no config#4841dustinblackman wants to merge 1 commit intolima-vm:masterfrom
dustinblackman wants to merge 1 commit intolima-vm:masterfrom
Conversation
Signed-off-by: Dustin Blackman <github@dustinblackman.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4791
When the guest agent starts up the kubernetes service watcher, it is incorrectly calling
kubectlwhen no kube config exists, falling back to the default kubernetes endpoint of127.0.0.1:8080. This PR adds a condition where if no kubernetes config is found, the function exits early without callingkubectl. The loop to check for if an kubernetes config exists remains unchanged.